Skip to content

London | 26-ITP-July | Raihan Sharif | Sprint 5 | Prep Exercises - #651

Open
RaihanSharif wants to merge 17 commits into
CodeYourFuture:mainfrom
RaihanSharif:sprint-5-prep-execises
Open

London | 26-ITP-July | Raihan Sharif | Sprint 5 | Prep Exercises#651
RaihanSharif wants to merge 17 commits into
CodeYourFuture:mainfrom
RaihanSharif:sprint-5-prep-execises

Conversation

@RaihanSharif

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I've created a new file for each of the exercies listed in the prep. Answered questions and made changes as required.

@RaihanSharif RaihanSharif added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 6, 2026

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on these, I have just one minor comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good explanations

Comment thread sprint-5-exercises/laptop_enums.py Outdated
return possible_laptops


# people = [

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment meant to be here?

@RaihanSharif RaihanSharif Aug 12, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, I commented these lines out from the original, as I felt they weren't necessary to accomplish the goal of the project. I meant to remove them.

Removed.

Comment thread sprint-5-exercises/laptop_enums.py
@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 12, 2026

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great,this task is complete now then

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants